react-component / react-component/table
Improve interface CustomizeComponent and interface GetComponentProps
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 618
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 2
Description
What happened?
In many examples, it uses more customized components other than HTMLElement, but the interface is not compatible.
export type CustomizeComponent<
P extends React.HTMLAttributes<HTMLElement> = React.HTMLAttributes<HTMLElement>
> = Component<P>;
// CustomizeComponent is permanently Component<React.HTMLAttributes<HTMLElement>>
export interface TableComponents<RecordType> {
table?: CustomizeComponent;
header?: {
wrapper?: CustomizeComponent;
row?: CustomizeComponent;
cell?: CustomizeComponent;
};
body?:
| CustomizeScrollBody<RecordType>
| {
wrapper?: CustomizeComponent;
row?: CustomizeComponent;
cell?: CustomizeComponent;
};
}
export type GetComponentProps<DataType> = (
data: DataType,
index?: number,
) => React.HTMLAttributes<HTMLElement>;
Maybe can fix
Add CustomizeCellProps generic type to TableProps, and improve TableComponents and GetComponentProps
interface TableProps<RecordType = unknown, CustomizeCellProps = unknown>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the definitions of TableProps, TableComponents, CustomizeComponent, and GetComponentProps, then inspect the repository's examples that use customized components. Done means the relevant interfaces accept customized component props through generics without losing type compatibility, with the existing examples remaining type-safe.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100