react-component / react-component/table

Event info not available on 'onExpand' event signature

Open
#416 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.4k
Forks
618
Avg merge
10h 19m
Merged PRs (30d)
2

Description

I have a controlled rc-table component. The information on which rows are expanded is in the Parent component. It decides whether to expand/collapse in each click.
Now, I need to implement some extra features: Expand all the children rows when the Ctrl key is pressed.

Problem: There's no enough information in the onExpand event signature. In this case, I need to access some information available in the Click's event.

Method Signature:
expandable.onExpand Function(expanded, record)

Can we have that information available?
Currently, I have a workaround for this problem. But it's not a pretty solution. As I said, it's a workaround.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the expandable.onExpand callback signature and the controlled expansion flow described in the issue. Determine how click-event information could be exposed so Ctrl-based expansion can be implemented, then verify that the resulting API supports the requested behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
api, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.