react-component / react-component/table
ExpandableRow does not use overridden cell component
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 618
- Avg merge
- 10h 19m
- Merged PRs (30d)
- 2
Description
I wanted to override table components with components prop, but if a table has a cell with expand icon, its cell is still rendered as <td> element:
Here you can see other cells use the components given in props:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/ExpandableRow.js around line 93 and compare the cell rendering with src/TableRow.js around line 220. Reproduce a table using the components prop with an expandable cell, then verify that the custom cell component is used for the expand-icon cell instead of a td element.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100