react-component / react-component/slider

stopPropagation breaks blur() events elsewhere

Open
#939 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Steps to reproduce:
Given: I have an input (unrelated to rc-slider), and a <Slider> element

  1. Click into the input. Expected: cursor blinks in input, focus is on input
  2. Click the slider drag handle
    Expected: a blur() event is called on the input
    Actual: no blur() event is called

I suspect this is because stopPropagation is called here. What is the reason for this call?

I will gladly open a PR to resolve this problem, but before I do it would be best for me to understand the problem that stopProgation is solving.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/Marks/Mark.tsx at the stopPropagation call linked in the issue, then reproduce the behavior with a focused input and a Slider drag handle. Determine why propagation is stopped and verify that the input receives its blur event while the slider's existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.