react-component / react-component/slider

onAfterChange

Open
#849 11 comments 11 reactions 2 assignees View on GitHub

@MadCcc is already working on this.

Since Aug 24, 2023.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

The change in https://github.com/react-component/slider/pull/812 added /** @deprecated It's always better to use onChange instead */ to onAfterChange.

I use both onChange and onAfterChange.
We have questions which we finalise, but this should only happen when the user has released the slider on the value they are setting it to. Is there an alternative to onAfterChange that will allow me to keep this behaviour once it is removed?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.