react-component / react-component/slider

How to prevent "marks" change function

Open
#840 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Hello,

I want to use the "onChange" function only on the slider area.

However, "onChange" function is not required for marks.
That's a rather big bug for my project.

  My rc-slider version =  ^9.7.5

👇👇👇 Current issue gif file 👇👇👇

ezgif com-gif-maker

ezgif com-gif-maker (1)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported behavior in rc-slider v9.7.5 with marks and an onChange handler, then trace how mark interactions and slider-area interactions are dispatched. Done means clicking marks no longer invokes onChange while dragging or changing the slider area still does, with a regression test covering both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.