react-component / react-component/slider
SliderProps type' ValueType stuck as `number | number[]`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
In our project, the ValueType needs to be number | undefined. The SliderProps type was updated to default its ValueType to number | number[]. It's using generics now so should be modifiable, but the Slider component itself is not setup to be passed a value for ValueType...
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the SliderProps type and the Slider component's generic declarations, since the issue says they currently disagree about ValueType. Confirm how a value of number | undefined is passed through the component and add or update the relevant type coverage. Done means SliderProps accepts the requested ValueType without the unwanted default restriction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100