react-component / react-component/slider
Feature Request: `testId` property or a way to pass `data-*` attributes to slider
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
It is convenient to use data-testid JSX/HTML-attribute for testing purposes. Set it to the root rc-slider HTML element.
React modal as example has the testId prop:
String
testIdthat renders adata-testidattribute in the DOM, useful for testing.
Example
<Slider testId="test-slider-locator" />
or
<Slider data-test-id="test-slider-locator" />
or something else
References
- motivation What's with the data-testid query?
data-testidnaming https://testing-library.com/docs/queries/bytestid/#overriding-data-testid
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name a file or test; start at the Slider entry point and trace the root HTML element. Compare the requested testId and data-* examples, then verify that the selected API places the attribute on the root element and that the behavior is covered by the existing slider tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100