react-component / react-component/slider

pushable has incorrect typing?

Open
#800 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

The title could be incorrect, but on the (maybe unofficial?) documentation, it says that "pushable" can be of type boolean or number. It is also present in the examples. However, looking in my download, in rc-slider/lib/common/Range.d.ts, pushable is boolean only. How do i achieve the affect of having a minimum distance between to points and having them pushable?

Here is the link to the documentation, and here is the link to the demo I found. I'm not sure if theyre official sources, because they seem to be outdated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with rc-slider/lib/common/Range.d.ts and compare its pushable declaration with the linked documentation and range demo. Verify whether number-valued pushable is supported by the package version; done means the supported type and minimum-distance behavior are clarified or the discrepancy is tracked for correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.