react-component / react-component/slider
Change types of arrays on props to ReadonlyArray
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
We use ReadonlyArray in typescript alot, but we get an error passing it to rc-slider, even though you do mutate the array. Changing it would only allow more types to be passed afaik.
I can make a PR if you indicate this would be accepted.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TypeScript prop declarations that currently use mutable array types, then check how those props are passed to rc-slider. Update the relevant array types to ReadonlyArray and verify that readonly inputs are accepted without changing runtime behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100