react-component / react-component/slider
onAfterChange not firing
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
In v9.2.3, it appears that onAfterChange is not firing. When manipulating the slider, I am seeing handleChange in my console but onAfterChange never appears afterwards.
<Slider
min={1}
max={1000}
defaultValue={100}
handleChange={value => {
console.log('handleChange');
}}
onAfterChange={value => {
console.log('onAfterChange', value);
}}
/>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Slider example from the issue and trace where handleChange and onAfterChange are dispatched. Confirm the expected callback behavior for slider interaction and add or update coverage for the reported case before verifying that onAfterChange fires with the value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100