react-component / react-component/slider

Range: Clicking on marks label will not update the slider

Open
#599 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Clicking on the mark labels of a range slider will not update the slider.

Steps to reproduce:

  1. got to the http://react-component.github.io/slider/examples/marks.html
  2. find the Range with marks or Range with marks and steps sliders
  3. click on any label

Expected:

The slider should be updated, the nearest (or last changed) handler should jump on the above the label.

Result:

The slider is not updated, the handlers are not moved at all.

The problem as I can see is that the value passed from onClickMarkLabel is totally ignored and the bounds are not recalculated, so the onChange handler will be fired with previous bounds.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Range mark-label click path through onClickMarkLabel and inspect how its value and bounds are passed to onChange. Reproduce the issue in the Range with marks and Range with marks and steps examples at the linked examples page. Done means clicking a mark label moves the appropriate handle and emits updated bounds.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.