react-component / react-component/slider

upgrade babel-runtime 6.x

Open
#592 1 comment 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Hello, I'm currently upgraded my babel configuration to newest one (from babel 6 to 7) and it worked great. But after I installed core-js 3 for polyfills, rc-slider started to give me errors.

ERROR in ../node_modules/core-js/library/fn/symbol/iterator.js
Module build failed: Error: ENOENT: no such file or directory, open 'xxxr/node_modules/core-js/library/fn/symbol/iterator.js'
 @ ../node_modules/babel-runtime/core-js/symbol/iterator.js 1:30-75
 @ ../node_modules/babel-runtime/helpers/typeof.js
 @ ../node_modules/babel-runtime/helpers/possibleConstructorReturn.js
 @ ../node_modules/rc-slider/es/Slider.js
 @ ../node_modules/rc-slider/es/index.js

Almost same error goes for other core-js 2

ERROR in ../node_modules/core-js/library/fn/symbol/index.js
ERROR in ../node_modules/core-js/library/fn/object/set-prototype-of.js
ERROR in ../node_modules/core-js/library/fn/object/get-prototype-of.js
...

My question is - why babel-runtime 6.x is required and 7 is not being used for rc slider?

Sorry if i'm posting this to wrong dependency but if I am - where should I post

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Babel configuration and the dependency paths shown in the trace, especially babel-runtime/core-js/symbol/iterator.js and rc-slider/es/Slider.js. Reproduce the reported build with core-js 2 and 3, then verify which babel-runtime version rc-slider resolves. Done means the dependency relationship and supported Babel/core-js combination are established.

Written by the indexing model from the issue text.

Assessment

Tech stack
babel, javascript, react
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.