react-component / react-component/slider

Why React is not a peerDependency?

Open
#589 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Hi! I ran into some weird errors since the inclusion of rc-slider in one of my libs due to duplicated copies of React being loaded.

Since my use case needs React lib as an external dependency in webpack config, I was wondering why React is not loaded as a peerDependency in rc-slider's package.json instead? Actually the same is true for rc-tooltip lib. Thanks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting rc-slider's package.json and the webpack configuration described in the report; check how React is declared and bundled. Compare that setup with the reported duplicate-React failure. Done means the dependency choice is explained or updated so this external-React use case is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, webpack
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.