react-component / react-component/slider

Tooltip remains open, when slider values are changed on mouse click

Open
#579 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Tooltip remains open sometimes when slider values are changed from mouse click, and is you want to close it you must press click outside the range component.
Then its called again the method onChange. So onChange method its called 2 times in that situation.
You can check here: http://react-component.github.io/slider/examples/handle.html on Range with custom tooltip . Just press a few times and you will notice the tooltip remains open.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the handle example at http://react-component.github.io/slider/examples/handle.html and reproduce the issue using Range with a custom tooltip. Trace the mouse-click path for changing slider values and verify that the tooltip closes normally and onChange is called only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.