react-component / react-component/slider

get rid of negative margin for handle

Open
#573 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

In my project we do not need for .rc-slider-handle to have negative margin. So I use CSS to remove this negative margin. But in this case when you move handle to the end the handle goes beyond the rail. Could you please calculate offset for handle taking account of handle width, paddings and borders?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the styles and positioning logic for .rc-slider-handle and the slider rail, then reproduce the endpoint case with the negative margin removed. Adjust the offset calculation to account for the handle width, padding, and borders, and verify that the handle remains within the rail at both ends.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.