react-component / react-component/slider

keyboard onBlur or press enter doesn't trigger onAfterChange

Open
#572 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

when navigating the slider using keyboard, it trigger onChange. I have a case where I need to trigger onAfterChange when the user click outside of slider or press the enter key. For now I can see the selection go away when it's blurred or enter key is pressed, but nothing happens after that. Such function doesn't exist?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the keyboard, blur, and Enter-key behavior in the slider, then trace the existing onChange and onAfterChange entry points. Done means the requested callback behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
accessibility, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.