react-component / react-component/slider
Page crashes when setting step={null}
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
When I set step={null}, it causes my chrome tab to crash(basically just loads forever, seems like an infinite loop somewhere).
Code:
<Slider
trackStyle={{ backgroundColor: theme.primary.red }}
handleStyle={{ borderColor: theme.primary.red }}
dots
onChange={onChange}
value={parseInt(value)}
css={{ margin: "auto", width: "50%" }}
marks={{
1: "1",
2: "2",
3: "3",
5: "5",
}}
step={null}
/>
Help appreciated. Thank you!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Chrome tab hang with the Slider example and step={null}, then trace how the component handles a null step value. Done means the example no longer hangs and a regression test covers this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100