react-component / react-component/slider

Moving more than one step with custom OnChange

Open
#497 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

Greetings! I've tried over and over and I can't seem to find a way to do this.

This is my handleChange function

  private handleChange = (newValue: number) => {
        if (newValue !== null) {
            this.setState({
                signalValue: newValue
            });
        }
    };

This is the Slider component

<SliderWithTooltip
                            value={params.signalValue}
                            style={{width: params.width}} max={params.maxRange}
                            min={params.minRange}
                            onChange={this.handleChange}
                            onAfterChange={this.onHandleAfterChange}
                        />

And i have attached a cloudapp link showing how it behaves.

https://cl.ly/0e703a357b4f

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported behavior with SliderWithTooltip, the supplied handleChange function, and the onChange/onAfterChange props. Compare the received newValue values with the requested movement shown in the linked recording. Done means establishing the expected multi-step behavior and identifying whether the report describes a slider defect.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.