react-component / react-component/slider

onAfterChange keeps the slider in focus state

Open
#495 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

When we slide the slider the focus is still there on the slider as a result when we click anywhere on the screen the click is used to remove that focus which calls the onAfterChange function again .

This was not there in 8.6.1 version . So probably must be introduced in 8.6.2.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the slider focus behavior described in the issue and compare versions 8.6.1 and 8.6.2, focusing on when onAfterChange runs after a slide and an outside click. Done means clicking elsewhere after sliding does not invoke onAfterChange a second time.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.