react-component / react-component/slider

Version 8.6.3 is a breaking version

Open
#485 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

We use rc-slider within a popup. The popup listens to onBlur to close. This is causing the popup to close while we are moving the slider.

onEnd = () => { this.setState({ handle: null, }, this.blur); this.removeDocumentEvents(); this.removeDocumentEvents(); this.props.onAfterChange(this.getValue()); this.props.onAfterChange(this.getValue()); } }

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names version 8.6.3 and the slider's onEnd handler, but no source file or test. Reproduce a slider inside a popup whose onBlur closes it, then trace the onEnd blur behavior. Done means moving the slider no longer closes the popup unexpectedly while the end-of-change callback still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.