react-component / react-component/slider
onInput?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
Right now onChange is doing what onInput is supposed to be doing: for sliders/ranges, the DOM spec gives change as being "the value after the user is done setting the input" while input is "the value while the user is manipulating the input", so it would be great if an onInput attribute was added to do what onChange does, and have onChange changed to only trigger when it's supposed to (and then spin a major version because that'll be a breaking change. But at least it'll bring the behaviour back in line with how inputs are supposed to work according to the DOM spec).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the slider currently handles its onChange attribute and compare that behavior with the DOM input and change event definitions described in the issue. Determine the appropriate onInput behavior and the conditions under which onChange should fire; done means both events match the stated DOM semantics and the breaking change is documented for a major release.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100