react-component / react-component/slider

Error while updating the slider value: Cannot read property 'toFixed' of undefined

Open
#456 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
768
Avg merge
11d 22h
Merged PRs (30d)
5

Description

There is an error in line#97 in lib > utils.js
return step === null ? closestPoint : parseFloat(closestPoint.toFixed(getPrecision(step)));

Please fix this error.

screen shot 2018-07-30 at 1 15 20 pm

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/utils.js at line 97 and reproduce the slider-value update described in the issue. Trace why closestPoint is undefined before toFixed; done when the update no longer throws this error and the relevant behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.