react-component / react-component/slider
Root class rules are overridden by style
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 768
- Avg merge
- 11d 22h
- Merged PRs (30d)
- 5
Description
When adding a className to the root element you might want to set a height for instance. This is overridden by the component style.
Options to fix:
- add a rootStyle prop
- document in the readme that this is the case and that you might need
!importantfor some things (this is what I do now but it feels inelegant)
EDIT:
Just found out there is also a style prop of course that works fine. It might be nice to document that :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue identifies the existing style prop as the working solution and suggests documenting it. Start with the README and its component props documentation; explain that style can be used for root styling, then verify that the documented behavior is clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100