react-component / react-component/select
Almost ineffective useMemo?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 938
- Forks
- 482
- Avg merge
- 15h 8m
- Merged PRs (30d)
- 2
Description
Hi everyone, I saw a useMemo with children props as its dependency, but react renews children references in every render, so is this useMemo used just to prevent rerender caused by internal state changes? I mean whenever the parent component re-renders, Select re-renders too, it's a little strange
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/generate.tsx#L454 and inspect the useMemo dependency involving children. Trace how Select renders during parent and internal state updates, then determine with maintainers whether the memoization should be changed or retained and document the expected rendering behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100