react-component / react-component/select
tagRender option and tag wrapper
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 938
- Forks
- 482
- Avg merge
- 15h 8m
- Merged PRs (30d)
- 2
Description
Hello! I have a component extending the Select with tags mode enabled.
I'd like to have a regular tag wrapper, but just change the inside of the tag.
Unfortunately the wrapper is not the same when we use the tagRender option and there is now way to control it.
I would need it to be always like the second one. Without the onMouseDown event and with the proper className.
Any reason why the current implementation is like that ?
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Selector/MultipleSelector.tsx at the linked tagRender branches around lines 146 and 156-162. Compare the wrapper behavior in both paths and verify that tagRender changes only the tag contents while the wrapper keeps the regular className and omits onMouseDown; the issue is complete when this behavior is consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100