react-component / react-component/select

The customizeInputElement type definition are wrong such that it would throw an error on type checks

Open
#516 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
938
Forks
482
Avg merge
15h 8m
Merged PRs (30d)
2

Description

https://github.com/react-component/select/blob/245b3b18a8815abc419ab71f9d4ad7c407f0b486/src/generate.tsx#L625-L626

Well, It would throw an error says that Type null is not assignable to type ReactElement and further caused references or inner component to cause error as expected.

Tell me if I got it wrong, thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/generate.tsx at lines 625–626 and inspect the customizeInputElement type definition. Run the project’s TypeScript checks to reproduce the reported null-versus-ReactElement error; done means the definition no longer produces that error for valid usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.