react-component / react-component/select

should allow 'hideAction' receive from parent props

Open
#336 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
938
Forks
482
Avg merge
15h 8m
Merged PRs (30d)
2

Description

https://github.com/react-component/select/blob/1a0834305e30591e95beedcb22b98cd68133159b/src/SelectTrigger.jsx#L147
The hideAction is hard code here, it should can be assign from parent props.
When give showAction 'hover', the hideAction should also can be set to hover too.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/SelectTrigger.jsx at line 147, where hideAction is hard-coded. Trace how showAction is received from parent props, then make hideAction configurable there and verify that setting both showAction and hideAction to hover produces the requested behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.