react-component / react-component/picker

【兼容性问题】低版本Chrome不支持getRootNode

Open
#882 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
304
Forks
345
Avg merge
2d 7h
Merged PRs (30d)
7

Description

这行代码里的getRootNode不兼容低于54版本的Chrome浏览器,求解。

https://github.com/react-component/picker/blob/master/src/PickerInput/RangePicker.tsx#L431

image

另一个组件SinglePicker的点击事件是另一种处理 这个组件在Chrome低版本上没问题
https://github.com/react-component/picker/blob/master/src/PickerInput/SinglePicker.tsx#L360

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/PickerInput/RangePicker.tsx around line 431 and compare its click handling with src/PickerInput/SinglePicker.tsx around line 360. Reproduce the issue in a Chrome version below 54, then verify that the RangePicker interaction no longer depends on the unsupported API and that the existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.