react-component / react-component/picker
Deprecated event.which property
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 304
- Forks
- 345
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 7
Description
Similar issue to react-component/select; https://github.com/react-component/select/issues/977
event.which is deprecated which is causing issues with @testing-library/user-event v14; https://github.com/testing-library/user-event/issues/1137
Deprecated: This feature is no longer recommended. Though some browsers might still support it, it may have already been removed from the relevant web standards, may be in the process of being dropped, or may only be kept for compatibility purposes. Avoid using it, and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.
It's recommended to switch over to event.code or event.key instead - https://github.com/testing-library/user-event/issues/842#issuecomment-1019528148
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the picker repository for uses of the deprecated event.which property, then inspect the surrounding event-handling code. Replace the usage with the appropriate event.code or event.key value and verify that interactions work with @testing-library/user-event v14.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100