react-component / react-component/picker
edit time using keyboard does not work correctly for dayjs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 304
- Forks
- 345
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 7
Description
i use https://ant.design/components/date-picker/ and dayjs
https://github.com/react-component/picker/blob/e7403734d8cde9c9403ae00c83c4da34625ede57/src/generate/dayjs.ts#L115
we should use strict parsing as in moment
dayjs(formatText, format, true)
I did not send pr because there is some wrong definition in dayjs .d.ts
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/generate/dayjs.ts around line 115 and compare the current parsing call with the strict-parsing example in the issue. Check the Day.js type definition mentioned by the reporter, then verify that keyboard-entered dates reject invalid formats and that the typings support the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100