react-component / react-component/picker

[Question] RangePicker with showTime and onChange / onCalendarChange behavior

Open
#487 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
304
Forks
345
Avg merge
2d 7h
Merged PRs (30d)
7

Description

Would like to know why onChange and onCalendarChange callbacks are only called when user press enter or click on the OK button when you have showTime props active? Is it a bug or a feature? I would like to change the range value each time a user change something (ie date or time) but it seems when the time picker is here you do not call change callbacks until they explicitly press enter or click OK button and this can be frustrating when you accidentally close the dropdown...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the RangePicker behavior with showTime enabled, comparing onChange and onCalendarChange when selecting dates or times versus pressing Enter or clicking OK. Trace the callback handling for this path; done means the behavior is explained and the intended callback timing is documented or clearly identified as a bug.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.