react-component / react-component/picker
generatePicker imports all locales, with huge impact on bundle size
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 304
- Forks
- 345
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 7
Description
When swapping out moment.js with either day.js or date-fns, the generatePicker function imports all of the locales.
This results in a huge bundle and totally not needed in a lot of use cases.
dateFns.ts#L26
Is there a way to get around this?
It seems a little silly to have pre-loaded all locales when you only need one :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/generate/dateFns.ts at the linked locale import and trace how generatePicker selects date-library locales. Compare the resulting bundle impact for a single-locale use case; done means locales are not all included when they are not needed, with the existing picker behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100