react-component / react-component/picker
Hours not redrawn when using use12Hours with disabledTime (and disable some hours) and switch between AM/PM
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 304
- Forks
- 345
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 7
Description
Hi guys, thanks for the great lib.
If you enable use12Hours and use disabledTime to disable some hours, the hours column isn't redrawn when you switch between AM and PM. The column only updates when you switch days.
Likely all that needs to happen is whatever's called on selecting a day needs to be called when selecting AM or PM.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing a time picker with use12Hours and disabledTime configured to disable selected hours. Trace the update path used when switching days and compare it with the AM/PM selection path; done means the hours column refreshes immediately when AM or PM changes, without requiring a day switch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100