react-component / react-component/picker

Huge bundle size when using with date-fns

Open
#125 4 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
304
Forks
345
Avg merge
2d 7h
Merged PRs (30d)
7

Description

This line
https://github.com/react-component/picker/blob/master/src/generate/dateFns.ts#L24
is importing all the locales from date-fns. I'm not sure how to do it to import only the default one so that the final bundle is not so big
image

If I find a solution I'll make a Pull Request. Thanks for this awesome library!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/generate/dateFns.ts line 24 and inspect how date-fns locales are imported. Reproduce the bundle-size issue shown in the report, then verify that the date-fns integration uses only the needed default locale rather than bundling all locales.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.