react-component / react-component/pagination

showTitle prop should also work for sizeChanger

Open
#370 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
674
Forks
333
Avg merge
12m
Merged PRs (30d)
1

Description

showTitle=false doesn't disable title for sizeChanger options.

https://codesandbox.io/s/agitated-rain-nm5cn?file=/src/App.js

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the linked CodeSandbox and inspect how sizeChanger options render their titles. Verify that showTitle=false prevents titles on those options, then confirm the behavior in the sandbox or relevant existing checks; done means sizeChanger options have no title when the prop is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.