react-component / react-component/pagination
Simple pagination does not support showTotal
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 674
- Forks
- 333
- Avg merge
- 12m
- Merged PRs (30d)
- 1
Description
When simple prop is true, the component does not render the text returned in showTotal prop.
I simply put the showTotal block before the simple pagination component conditional and added a text rendering before the first li tag as it is originally the regular pagination code and it seemed to work.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the pagination component's simple-mode conditional and the existing showTotal rendering path. Confirm how regular pagination renders the total, then make simple mode render the same showTotal text and verify that the output appears before the first li element.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100