react-component / react-component/pagination
Page Size dropdown has extra characters
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 674
- Forks
- 333
- Avg merge
- 12m
- Merged PRs (30d)
- 1
Description
Looking at https://react-component.github.io/pagination/?path=/story/rc-pagination--sizer and then attempting to implement the "sizer" in my code. When I enable showSizeChanger, each select option appears to have (Chinese?) characters after it. However I changed the locale prop to "en_US" so now it just has "undefined" after each number.
See screen shot:
The "sizer" only appears to work with rc-select, but this happens. How do I get rid of the undefined?
Example of what it looks like in Chrome Components:
Thanks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue at the linked rc-pagination sizer story with showSizeChanger enabled and locale set to en_US. Inspect how the size options are rendered with rc-select, then verify that the extra characters or undefined text no longer appear after the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100