react-component / react-component/notification
Unable to close notification since on release v4.5.0
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 384
- Forks
- 118
- Avg merge
- 1h 18m
- Merged PRs (30d)
- 2
Description
Our component library has been using rc-notification, and closing the notification started to not work since release v4.5.0. To be more specific, removeNotice method gets called, and I see that the notices array in the React state of rc-notification module removes the correct item. However, the state change does not get reflected in the UI, and the notification does not disappear from the screen.
Expected behavior:
- Invoking "removeNotice" method with valid key correctly removes the notification from the UI
Current behavior:
- Clicking on the close icon that calls "removeNotice" method removes the notice in the state correctly, but the notification does not disappear from the UI
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the removeNotice entry point and the notices array in the rc-notification module, then follow how the React state is rendered into the UI. Confirm that removing a valid key causes the corresponding notification to disappear when the close icon invokes removeNotice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100