react-component / react-component/menu
Feature: Enable rendering a different element
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 701
- Forks
- 266
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 3
Description
Due to accessibility and UX reasons I want to render actual link elements instead of li elements.
This can currently only achieved by using <Menu.Item> which gives me an error notification, that it is deprecated and items should be used.
But with the items prop it seems to me there's no way to achieve the same. I guess I could abuse the label prop for that matter by making it full size and reconstruct the default layout of said element so it works the same way with the icon and what not.
Ideally, I'd want an option to change the type of the list element that's being rendered.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Menu.Item API and the items prop behavior described in the issue, then trace where the menu's list element is selected. The change is complete when consumers can opt to render an actual link element through items while retaining the standard icon and layout behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100