react-component / react-component/menu

menu.item disabled prop should still allow mouseenter/leave

Open
#436 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
701
Forks
266
Avg merge
4d 11h
Merged PRs (30d)
3

Description

The menu.item disabled prop should still allow mouseenter/leave, while disabling click and keydown. Alternatively, allow onClick or href prop to be passed in to override the components href/onclick prop.

When using something like rc-toolip inside the MenuItem as a child component, it will not trigger due to no event bubbling from mouse events.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the MenuItem event handling for the disabled prop and trace how mouseenter, mouseleave, click, and keydown are currently handled. Check how a child such as rc-tooltip receives mouse events. Done means disabled items still support the requested hover behavior while click and keyboard activation remain disabled, with the chosen override behavior documented or tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.