react-component / react-component/menu
Prevent the duplicated aria-hidden element being attached to DOM
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 701
- Forks
- 266
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 3
Description
Thanks for your work on #385 @zombieJ.
Is there a way to prevent the aria-hidden element being added to the DOM?
The upgrade to antd 4.16 has caused many issues in our app. Our component and browsers tests now fail due to duplicate elements and nested Modals that use portals within the Menu.Items now display twice.
Preventing the hidden component being attached to the DOM would prevent both of these issues.
Originally posted by @patrickomeara in https://github.com/react-component/menu/issues/385#issuecomment-887179618
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the aria-hidden behavior discussed in issue #385 and reproduce the duplicate elements and nested Modal rendering described here. Trace where the hidden element is attached to the DOM, then verify that it is no longer attached while menu and portal behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100