react-component / react-component/menu
Custom expandIcon doesn't work in horizontal mode
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 701
- Forks
- 266
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 3
Description
Hey there, as in title for some reason expandIcon doesn't insert its contents to dom like on vertical mode. Is that intentional? I don't see anything in the docs which would suggest that behavior.
CodeSandbox link:
https://codesandbox.io/s/broken-sky-4fewl?file=/src/index.js
I used customIcon example, please forgive me for no styling :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the linked CodeSandbox and compare the customIcon example in vertical and horizontal modes. Trace why the custom expandIcon content is absent from the horizontal-mode DOM, then verify that the custom icon renders there as it does in vertical mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100