react-component / react-component/menu

Mixing of require() and import statement

Open
#246 8 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
701
Forks
266
Avg merge
4d 11h
Merged PRs (30d)
3

Description

Assuming that this project is being developed using ES modules, there is an issue on the src/DomWrap.jsx and src/utils.js files.

There is a mix of require() (CommonJS syntax) and import (ES6 module syntax).
This causes problems when trying to bundle something that depends on this component (in my case that something antd) and bundling it with rollup (that takes ES6 modules as a default).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the module statements in src/DomWrap.jsx and src/utils.js, then reproduce the reported Rollup bundling problem with a dependent component. Done means those files no longer mix CommonJS require() and ES module import syntax, and bundling the dependency succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, rollup
Domain
build-system, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.