react-component / react-component/menu

close menu on click

Open
#121 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
TypeScript
Stars
701
Forks
266
Avg merge
4d 11h
Merged PRs (30d)
3

Description

I have to build a menu which includes options but also actions. For this reason I set selectable to false. What would be the best way to destroy the popup after an action is clicked? Using a state property to populate or not the menu doesn't seem to work well. Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how selectable=false affects menu action clicks and popup lifecycle in the menu implementation. Determine the supported way for an action click to close the popup, then verify the behavior with the relevant menu interaction tests; done means action items close the popup without requiring external state.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.