react-component / react-component/input-number

When replace the `.` with `decimalSeparator`, should replace the last `.`

Open
#229 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
323
Forks
188
Avg merge
20h 3m
Merged PRs (30d)
1

Description

After the value is formatted, there maybe multiple . in the string, the last . should be replaced by decimalSeparator instead of the first one.
https://github.com/react-component/input-number/blob/master/src/index.js#L453

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The relevant entry point is src/index.js at line 453. Read the formatting and decimalSeparator handling there, then verify that a formatted value containing multiple periods replaces the last period while preserving earlier ones.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.