react-component / react-component/image
should not use `div` wrapper
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 213
- Forks
- 124
- Avg merge
- 47m
- Merged PRs (30d)
- 1
Description
When i use the component in markdown or mdx, the generated codes a bit like:
<p>
<div class="rc-image" style="width: 200px;">
<img class="rc-image-img" src="https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png" />
</div>
</p>
However, the P element represents a paragraph. It cannot contain block-level elements (including P itself).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by tracing the component's generated markup when used in Markdown or MDX, then verify the output shown in the issue no longer places the image's div wrapper inside a p element.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100