react-component / react-component/image
Image.tsx中的getImgRef似乎并无作用
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 213
- Forks
- 124
- Avg merge
- 47m
- Merged PRs (30d)
- 1
Description
getImgRef似乎并没有发挥预期的作用，onLoad()方法并且if (img?.complete && (img.naturalWidth || img.naturalHeight)) 这行代码触发，而是img自身的onLoad事件，getImgRef和isLoaded去掉之后似乎并无影响？
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Image.tsx and trace getImgRef, isLoaded, and the onLoad handler, including the check for img?.complete and naturalWidth or naturalHeight. Compare their behavior with the image element's own onLoad event and determine whether the questioned code has observable effects. Done means the redundant logic is either removed safely or its required behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100