react-component / react-component/dropdown
getPopupContainer return document.documentElement will make a crash
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 181
- Forks
- 112
- Avg merge
- 12h 52m
- Merged PRs (30d)
- 2
Description
getPopupContainer = () => document.documentElement let dom-align crash (Uncaught TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.)
should add some protect?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the getPopupContainer callback into the dropdown positioning path and the dom-align call that receives its result. Reproduce the document.documentElement case, then verify that the protection prevents the reported getComputedStyle crash without breaking normal container handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100