react-component / react-component/drawer

Bug: ClassName prop is not merged correctly

Open
#413 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
425
Forks
108
Avg merge
2h 1m
Merged PRs (30d)
1

Description

ClassName prop is not merged properly or set on the parent element.

Screen Shot 2023-03-24 at 5 38 55 PM
Screen Shot 2023-03-24 at 5 39 10 PM

It appears to be set now on the rc-drawer-content
Screen Shot 2023-03-24 at 6 14 41 PM

Expected results: to be set on the root component as in previous versions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported className behavior in the drawer component, comparing the current placement on rc-drawer-content with the expected root-component placement from previous versions. Confirm the fix by checking that the supplied className is merged and applied to the root element rather than only to the content element.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.